Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing color in the material on runtime won't work #43

Open
benzsuankularb opened this issue Mar 14, 2024 · 1 comment
Open

Changing color in the material on runtime won't work #43

benzsuankularb opened this issue Mar 14, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@benzsuankularb
Copy link
Sponsor

Changing "color" in the material on runtime won't work.

It seems like propsPrimitive didn't have color property inherited from Material class.
(https://github.com/0beqz/realism-effects/blob/main/src/gbuffer/material/GBufferMaterial.js)

let props = Object.keys(gBufferMaterial)

props = props.filter(
	key => !key.startsWith("_") && !key.startsWith("is") && key !== "uuid" && key !== "type" && key !== "transparent"
)

const propsPrimitive = props.filter(
	key => typeof gBufferMaterial[key] === "string" || typeof gBufferMaterial[key] === "number"
)
@0beqz
Copy link
Owner

0beqz commented Apr 5, 2024

Thanks for the reporting, I'll look into fixing it.

@0beqz 0beqz added the bug Something isn't working label Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants