Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Effectively deep-freeze Query objects #38

Open
1 task
0xMochan opened this issue Jul 25, 2023 · 0 comments
Open
1 task

Effectively deep-freeze Query objects #38

0xMochan opened this issue Jul 25, 2023 · 0 comments
Labels
enhancement New feature or request internal related to an internal change

Comments

@0xMochan
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
subgrounds/query.py has all objects related to the AST of GraphQL. Currently, every object is frozen, but nested fields of said objects are not (such as nested lists and dicts). This means the greater objects of Document, etc are not hashable.

Describe the solution you'd like
Ensure all query objects are hashable by using immutable data structures.

Additional context
Likely should be considered with a general refactor / subpackage breakdown of subgrounds/query.py).

Implementation checklist

  • Task 1
@0xMochan 0xMochan added enhancement New feature or request internal related to an internal change labels Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request internal related to an internal change
Projects
None yet
Development

No branches or pull requests

1 participant