Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for multiple rarity calculation methods #2

Open
0xSooki opened this issue Oct 1, 2022 · 7 comments
Open

Add support for multiple rarity calculation methods #2

0xSooki opened this issue Oct 1, 2022 · 7 comments
Assignees
Labels
enhancement New feature or request

Comments

@0xSooki
Copy link
Owner

0xSooki commented Oct 1, 2022

Expected Behaviour

Be able to select between multiple rarity calculation methods (see methods here)

Current Behaviour

As of now it only uses one method

Detailed Description

The users should be able to select between the different rarity calculation methods & generate the data based on the selected method

Possible Implementation

  • Create a rarity.js file
  • Create functions for the different methods
  • Implement these functions in the main.js file
@0xSooki 0xSooki added enhancement New feature or request hacktoberfest labels Oct 1, 2022
@prateekvarma
Copy link

Hi @0xSooki I'd like to take a shot at this one.

(participating for Hacktoberfest)

@0xSooki
Copy link
Owner Author

0xSooki commented Oct 2, 2022

Haii, sure, go ahead keep in mind that this is a bit harder issue to tackle

@fekete965
Copy link
Contributor

@0xSooki I have already extracted some of the functionalities in my PR.
@prateekvarma if you still wish to work on this issue, you could rebase on top of my PR #6

@prateekvarma
Copy link

Thanks @fekete965 and @0xSooki

@0xSooki
Copy link
Owner Author

0xSooki commented Oct 5, 2022

@prateekvarma any progress towards the issue?

@prateekvarma
Copy link

Hi @0xSooki my apologies, I'm still doing some tutorials and lessons from Alchemy. Haven't worked with anything related to web3 yet. I will post an updated soon.

@0xSooki
Copy link
Owner Author

0xSooki commented Oct 6, 2022

It's okay, take your time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants