Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with Eleventy 2.x.x #55

Open
j9t opened this issue Jun 24, 2024 · 4 comments
Open

Compatibility with Eleventy 2.x.x #55

j9t opened this issue Jun 24, 2024 · 4 comments
Labels
bug Something isn't working on hold

Comments

@j9t
Copy link

j9t commented Jun 24, 2024

When doing a brief test the other week, the latest release seems only compatible with Eleventy 3.0.0 Alpha.

Did I miss something (on the road and well might have!), or is there a path forward here that allows users to keep using the latest version of this plugin with 2.x.x, or until Eleventy 3 is stable?

Right now, the release makes for a pretty inconvenient situation for anyone automating dependency management (e.g., Dependabot, Depfu, and similar PRs can’t be merged).

@lyzadanger
Copy link

Same issue here; dependabot update (PR) for this package @2.0.1 breaks build with Eleventy @2.0.1.

@zachleat
Copy link
Member

zachleat commented Jun 24, 2024

Sorry folks, this is my fault. I should have put the RSS plugin on a prerelease channel.

We’re coming into the final stages before shipping Eleventy Core 3.0 stable and the latest major version of the RSS plugin is only compatible with Eleventy Core 3.0 and above. The 3.0 compatibility was a breaking change (and a major version bump) for the RSS plugin in v2.0.0 and newer.

It should have shown an incompatibility error for you (which is hopefully why you’re here!)

Is dependabot doing something undesirable here with major version bumps in dependencies?

Release notes for RSS plugin v2.0.0: https://github.com/11ty/eleventy-plugin-rss/releases/tag/v2.0.0

@j9t
Copy link
Author

j9t commented Jun 25, 2024

Dependabot and Depfu seem to be behaving correctly, in informing about an major update to the RSS plugin. That that requires moving the main dependency (Eleventy) from stable to alpha is not clear, unfortunately, and a tough call even for early adopters :)

For anyone liking to use stable releases and keeping their dependencies up-to-date this isn’t a great situation right now, but it seems that’s belaboring the point :)

@frankieroberto
Copy link

Same issue here, on a project which uses a plugin which uses eleventy-plugin-rss - see frankieroberto/nhsnotes#31

I think the root cause of why Dependabot didn't catch this (and you only get the error at build time) is that Eleventy version 3 is only specified in the package.json within "11ty": {"compatibility": ">=3.0.0-alpha.13"}, rather than as an npm dependency (which Dependabot would’ve caught).

Is there any reason for this?

@zachleat zachleat added bug Something isn't working on hold labels Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working on hold
Projects
None yet
Development

No branches or pull requests

4 participants