Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support file modify time strategy #11

Open
h4kuna opened this issue Mar 8, 2023 · 2 comments
Open

Support file modify time strategy #11

h4kuna opened this issue Mar 8, 2023 · 2 comments

Comments

@h4kuna
Copy link
Contributor

h4kuna commented Mar 8, 2023

I use on simple project own strategy which implement VersionStrategyInterface. Read filemtime and this integer is version for file. /style.css?version=20012009.

Want you add to your library?

I have library h4kuna/assets, but i want to use symfony/asset and i found your library, therefore my is abandoned.

For production mode during the request is builded cache with files, add new or use exists. File is saved on the end of request.
For development the cache is off.

All implementation are two files.

@h4kuna
Copy link
Contributor Author

h4kuna commented Mar 13, 2023

ping @tg666

@tg666
Copy link
Collaborator

tg666 commented Mar 15, 2023

Hi, I'm sorry for the delay.
I've looked at your package and we have no problem with it, as for adding a custom VersionStrategy that will include the logic from https://github.com/h4kuna/assets/blob/master/src/CacheAssets.php

But I think your CacheBuilder is already a bit out of scope for this package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants