Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct implementation of filter and coco_init for types EuclideanVector and EuclideanMatrix #100

Open
MatthiasSachs opened this issue Jan 8, 2022 · 3 comments
Assignees

Comments

@MatthiasSachs
Copy link
Collaborator

Currently, the code for both EuclideanVector and EuclideanMatrix treats the zero-correlation and the 1-correlation case by if-clauses, respectively, e.g.,

function filter::EuclideanMatrix, grp::O3, bb::Array)
   if length(bb) == 0  # no zero-correlations allowed 
      return false 
   end
   if length(bb) == 1 #MS: this line could be removed, I think...
      return true
   end

Can we remove either or both of these if-clauses?

How would we correctly implement coco_init(::EuclideanMatrix{CT}) and coco_init(::EuclideanVector{CT}), e.g.,

coco_init(::EuclideanMatrix{CT}) where {CT<:Real} = [EuclideanMatrix(SMatrix{3,3,Complex{CT},9}([1.0,0,0,0,1.0,0,0,0,1.0]))]  

? Are these actually needed?

@cortner
Copy link
Member

cortner commented Jan 9, 2022

hm - the zero-correlations clause is odd since we implement zero-correlations explicitly elsewhere.

@cortner
Copy link
Member

cortner commented Jan 9, 2022

Should we celebrate Issue #100 :)

@MatthiasSachs
Copy link
Collaborator Author

If celebrating it means ignoring it for now, I am all in...^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants