Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Derivatives for EuclideanMatrix #101

Open
MatthiasSachs opened this issue Jan 8, 2022 · 1 comment
Open

Derivatives for EuclideanMatrix #101

MatthiasSachs opened this issue Jan 8, 2022 · 1 comment

Comments

@MatthiasSachs
Copy link
Collaborator

MatthiasSachs commented Jan 8, 2022

The test

@info(" ... derivatives")
_rrval(x::ACE.XState) = x.rr
for ntest = 1:30
   Us = randn(SMatrix{3, 3, Float64,9 }, length(Xs))
   C = randn(typeof.val), length(basis))
   F = t -> sum( sum(c .* b.val)
                 for (c, b) in zip(C, ACE.evaluate(basis, ACEConfig(Xs + t[1] * Us))) )
   dF = t -> [ sum( sum(c .* db)
                    for (c, db) in zip(C, _rrval.(ACE.evaluate_d(basis, ACEConfig(Xs + t[1] * Us))) * Us) ) ]
   print_tf(@test fdtest(F, dF, [0.0], verbose=false))
end
println()

needs to be adapted for EuclideanMatrix ? That is, if we want to implement/use derivatives of matrix-valued equivariant functions w.r.t. to position ...

@cortner
Copy link
Member

cortner commented Jan 11, 2022

Let's not make that a requirement for the current PR, but leave it open so that at some point it can be addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants