Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite ACE.jl as a Graph #116

Open
cortner opened this issue Feb 2, 2022 · 1 comment
Open

Rewrite ACE.jl as a Graph #116

cortner opened this issue Feb 2, 2022 · 1 comment

Comments

@cortner
Copy link
Member

cortner commented Feb 2, 2022

In order to properly leverage the AD eco-system we will need to rewrite ACE.jl as a graph. I see no other way to continue to maintain and grow it in a systematic and disciplined way. This issue is to discuss what is involved before we start looking into it.

@cortner
Copy link
Member Author

cortner commented Mar 9, 2022

  • rewrite the XScal1pBasis to be a generic 1PBasisComponent that stores a general basis; (cf PR WIP: Rewrite 1p Basis #120 )
  • explore whether there should be a separate continuous and discrete (categorical) B1pComponent
  • implement frule for basis derivatives and rrule for model derivatives
  • Implement a generic Compose object that will simplify the composition of basis pieces.
  • Implement the linear transformation of the 1PBasisComponent as a transformation object of the innermost basis.

Rejected change (for now)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant