Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compatibility with hyperduals #60

Closed
CheukHinHoJerry opened this issue Aug 3, 2023 · 4 comments
Closed

compatibility with hyperduals #60

CheukHinHoJerry opened this issue Aug 3, 2023 · 4 comments

Comments

@CheukHinHoJerry
Copy link
Collaborator

CheukHinHoJerry commented Aug 3, 2023

We should probably introduce a new Union type instead of doing something like:

_valtype(::GaussianBasis, T::Type{<: Real}) = T
_valtype(::GaussianBasis, T::Type{<: Hyper{<:Real}}) = T

every time.

Due to this there is an issue with rtrig + hyperduals that I did a quick fix so that Bernie can use it. I will probably create a PR later today together with the above issue.

@cortner
Copy link
Member

cortner commented Aug 27, 2023

how does this relate to #27

@CheukHinHoJerry
Copy link
Collaborator Author

I think not quite related to SINGLE/BATCH. This is just something to reduce code repetition.

@cortner
Copy link
Member

cortner commented Aug 27, 2023

FWIW this repetition doesn't bother me at all. It seems very minor, just like documenting what type of inputs we allow. Why is it a problem?

@CheukHinHoJerry
Copy link
Collaborator Author

CheukHinHoJerry commented Aug 27, 2023

hmm what you say sounds right. I fixed this problem for multiple basis and that's why I think this might be an issue. Now I look at it again it should be minor. Will close this issue now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants