Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle reserved names in PEtab parameter mapping #2461

Open
dweindl opened this issue Jun 18, 2024 · 3 comments
Open

Handle reserved names in PEtab parameter mapping #2461

dweindl opened this issue Jun 18, 2024 · 3 comments
Labels
bug PEtab PEtab-import related

Comments

@dweindl
Copy link
Member

dweindl commented Jun 18, 2024

Some model entity IDs are replaced by amici_{actual_id} during model import, but the current PEtab parameter mapping generated by amici.petab.parameter_mapping.create_parameter_mapping will contain the original IDs instead of the amici-model-IDs. This needs to be changed.

See ICB-DCM/pyPESTO#1418

@dweindl dweindl added bug PEtab PEtab-import related labels Jun 18, 2024
@dweindl
Copy link
Member Author

dweindl commented Jun 18, 2024

@FFroehlich : Do you see a problem with keeping the original IDs as parameter/state/... IDs and only using the prefixes in the sympy / C++ symbols? This would anyways be more convenient for users.

@FFroehlich
Copy link
Member

@FFroehlich : Do you see a problem with keeping the original IDs as parameter/state/... IDs and only using the prefixes in the sympy / C++ symbols? This would anyways be more convenient for users.

sounds good!

@dweindl
Copy link
Member Author

dweindl commented Jun 19, 2024

Note for implementation: This will require moving the reserved-names handling from SbmlImporter to DEModel or DEExporter. This would anyways be a good idea. In particular, in the context of potentially extracting SBML to ODE conversion from AMICI into a separate package in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug PEtab PEtab-import related
Projects
None yet
Development

No branches or pull requests

2 participants