Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deeper Spark avro integration (?) #194

Open
cerveada opened this issue Feb 23, 2021 · 3 comments
Open

Deeper Spark avro integration (?) #194

cerveada opened this issue Feb 23, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@cerveada
Copy link
Collaborator

When Abris started it provided many features that were not available in Spark. This has changed and now avro Spark is capable to do many of those feature.

Abris is still useful because it supported the Confluent Avro format and provides Schema registry client abstractions, but it may be not the best solution to add new features that are already part of Spark.

A Better solution could be to use Spark expressions directly from Abris and just wrap them in Abris layer that will deal with the confluent format. That would allow us to provide the underlying features and at the same time keep the Abris functionality.

This might be challenging since the spark avro expressions are private and not designed to be used this way, but it seems to be doable.

This issue is still up for a discussion.

@cerveada cerveada added the enhancement New feature or request label Feb 23, 2021
@cerveada cerveada changed the title Deeper Spark avro integration Deeper Spark avro integration (?) Feb 23, 2021
@kevinwallimann
Copy link
Collaborator

For example, za.co.absa.abris.avro.sql.AvroDeserializer is a copy of org.apache.spark.sql.avro.AvroDeserializer (from spark version 2.4) with a few changes. It would be better to somehow reuse the original implementation otherwise, ABRiS' AvroDeserializer will diverge with future spark versions.

@cerveada
Copy link
Collaborator Author

cerveada commented Nov 2, 2021

I did some investigation and the AvroDeserializer changes were caused by use of ScalaDatumReader (in Abris 3.0.0) that was returning different objects then the ones that are normally on input of AvroDeserializer.

ScalaDatumReader is not used any more, so it looks like we can use the standard version of AvroDeserializer now.

@cerveada
Copy link
Collaborator Author

cerveada commented Nov 3, 2021

Part of this ticket is implemented as #240

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants