Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query: What is supposed to happen with multiple <materialx> tags in a document ? #1835

Open
kwokcb opened this issue May 24, 2024 · 1 comment

Comments

@kwokcb
Copy link
Contributor

kwokcb commented May 24, 2024

Query

I just accidently came across this. But if you have multiple <materialx></materialx> blocks what is supposed to occur ?

Currently it will just read the first block and discards subsequent blocks without any error / warning.
A trivial thing, (and assume it's just how the parser works?) but users may become confused if some content does not read in.

@jstone-lucasfilm
Copy link
Member

This is a good question, @kwokcb, and my initial thought is that documents with multiple materialx elements should be considered invalid, and should generate a warning in Document::validate. That would allow the current parser behavior to remain unchanged, but would provide guidance for exporters that unintentionally create this category of invalid documents.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants