Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HwTimeNode hardcodes frame rate in generated code instead of using the fps uniform #1874

Open
JGamache-autodesk opened this issue Jun 7, 2024 · 0 comments

Comments

@JGamache-autodesk
Copy link
Contributor

To test: connect a ND_time_float node to the base color of a standard_surface.

Looking at generated code, I see:

    float time_out = u_frame / 24.000000;

where I should instead see:

    float time_out = u_frame / time_fps;

This means changing the fps value is a topological change that requires recompiling the shader.

Is this per specification (which means there is a missing uniform="true" metadata in the fps input of the time NodeDef), or is it something that should be fixed in HwTimeNode.cpp to use shadergen.emitInput(fpsInput, context, stage); instead of shadergen.emitString(fps, stage);?

@jstone-lucasfilm jstone-lucasfilm changed the title The HwTimeNode is hardcoding the frame rate in the generated code instead of using the fps uniform HwTimeNode hardcodes frame rate in generated code instead of using the fps uniform Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant