Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: Top level inputs not working in code generation #1915

Open
kwokcb opened this issue Jul 2, 2024 · 0 comments
Open

Regression: Top level inputs not working in code generation #1915

kwokcb opened this issue Jul 2, 2024 · 0 comments

Comments

@kwokcb
Copy link
Contributor

kwokcb commented Jul 2, 2024

Issue

A top-level input is not handled properly for code generation anymore.
This is came up before and was fixed (think around 1.38.9/10 time-frame) but appears to be broken again in main.

Steps

Load the resources/Materials/TestSuite/stdlib/nodegraphs/top_level_input.mtlx test file.

<?xml version="1.0"?>
<materialx version="1.39" colorspace="lin_rec709">
  <surfacematerial name="surfacematerial" type="material" xpos="17.246376" ypos="-15.689655">
    <input name="surfaceshader" type="surfaceshader" nodename="surface_unlit" />
  </surfacematerial>
  <input name="input_color3" type="color3" value="0, 0, 1" xpos="10.905797" ypos="-15.982759" />
  <surface_unlit name="surface_unlit" type="surfaceshader" xpos="14.231884" ypos="-16.241379">
    <input name="emission_color" type="color3" interfacename="input_color3" />
  </surface_unlit>
</materialx>

It may load properly initially in the desktop node editor (render blue which is the top level input colour), but then if you re-evaluate it, or modify any value it will become while again.

Looking at the output code, the top-level input does not seem to be considered anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant