forked from AdaGold/BankAccounts
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bank Accounts - Wave 3 #72
Open
kedevlin
wants to merge
7
commits into
Ada-C4:KED/master
Choose a base branch
from
kedevlin:KED/master
base: KED/master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
b79bdfe
Add wave 3
kariabancroft 2d4d850
Merge remote-tracking branch 'upstream/master' into KED/master
kedevlin d08e197
Created SavingsAccount class with updated withdraw method
kedevlin fe366fd
Added add_interest method to SavingsAccount
kedevlin cd908c1
Added CheckingAccount class with withdraw and withdraw check methods
kedevlin 43f909a
updated withdraw check method, added reset_check method
kedevlin 0440811
Removed @check_fee variable
kedevlin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
require './BankAccounts.rb' | ||
class CheckingAccount < Bank::Account | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same comment in this class with regards to adding some whitespace between method definitions to provide some additional logical separation |
||
attr_reader :check_count | ||
def initialize(ident, balance, open_date) | ||
super | ||
@check_count = 0 | ||
end | ||
def withdraw(amount) | ||
amount += 100 | ||
super | ||
end | ||
def withdraw_using_check(amount) | ||
if amount > (@balance + 1000) | ||
puts "Not enough fundz!" | ||
else | ||
if @check_count < 3 | ||
@balance -= (amount + 100) | ||
@check_count += 1 | ||
else | ||
@balance -= (amount + 300) | ||
end | ||
return @balance | ||
end | ||
end | ||
def reset_checks | ||
@check_count = 0 | ||
end | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
require './BankAccounts.rb' | ||
class SavingsAccount < Bank::Account | ||
def initialize(ident, balance, open_date) | ||
@ident = ident.to_i | ||
@balance = balance.to_i | ||
@min_balance = 1000 | ||
check_valid_balance | ||
@open_date = DateTime.strptime(open_date, "%Y-%m-%d %H:%M:%S %z") | ||
end | ||
def withdraw(amount) | ||
if amount > (@balance - @min_balance - 200) | ||
puts "You must maintain a $10 minimum balance!" | ||
return @balance | ||
else | ||
super | ||
@balance -= 200 | ||
end | ||
end | ||
def add_interest(rate) | ||
interest = @balance * (rate.to_f/100) | ||
@balance += interest | ||
return interest | ||
end | ||
end |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the way you used this method to check the balance, I would recommend adding whitespace between the
end
from a previous method and thedef
of a new method