final wave of task list by Audrey #104
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and show for people
…g in person index
| def count_incomplete | ||
| t = self.tasks | ||
| incomplete = t.where(completed_date: nil) | ||
| incomplete.length |
There was a problem hiding this comment.
Generally we should prefer to use count on ActiveRecord relations (the array-link objects that are returned by all and where), because they "compose" together better and allow ActiveRecord to use more efficient SQL code.
If you try it out in rails console vs. using length you should be able to see how the generated SQL code is different.
|
Thanks for the comments, Charles! I hadn't even been thinking about whether I was putting id's on elements that are repeated from a loop. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It isn't all that beautiful, but it works.