Final wave (4) #106
Open
Final wave (4) #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| class Person < ActiveRecord::Base | ||
| has_many :tasks | ||
|
|
||
| def self.incomplete(pers_id) |
There was a problem hiding this comment.
I like the idea to use a class method here to extend the vocabulary associated with the Person model!
As we'll seen soon enough, you can actually move this method into the Task class and set tasks = Task.all instead of person.tasks (no longer any need for a pers_id parameter).
This will allow you to view all incomplete tasks with Task.incomplete -- however, it will also allow you to view the incomplete tasks for a single person with person.tasks.incomplete.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This wave was more manageable for me to wrap my head around than the others. I think drawing out the relationships helped. I feel slow - I finish HOURS after everyone else.