Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight dangerous filters in the user interface #758

Open
Sergey-Lyapin opened this issue Apr 3, 2024 · 3 comments
Open

Highlight dangerous filters in the user interface #758

Sergey-Lyapin opened this issue Apr 3, 2024 · 3 comments

Comments

@Sergey-Lyapin
Copy link

Sergey-Lyapin commented Apr 3, 2024

Issue Details

Some filters break popular services, we should warn users about it by highlighting these filters in the UI.
For example 1Hosts (Pro) breaks Facebook services.
AdguardTeam/HostlistsRegistry#50

Proposed solution

Highlight the filter with a color, text warning, etc.

Alternative solution

No response

@ameshkov
Copy link
Member

ameshkov commented Apr 5, 2024

@Chinaski1
The idea is that we'd like to label some blocklists as problematic in HostlistsRegistry.

When a blocklist is labeled with this tag:

  1. It should be clear from the dashboard interface that the blocklist is problematic.
  2. When the user tries to enable it, we should warn them that this blocklist is known to be breaking stuff.

@Chinaski1
Copy link
Member

Internal ID: AGDNS-2041/42

@KnightmareVIIVIIXC
Copy link

KnightmareVIIVIIXC commented Jul 2, 2024

@Chinaski1 The idea is that we'd like to label some blocklists as problematic in HostlistsRegistry.

When a blocklist is labeled with this tag:

  1. It should be clear from the dashboard interface that the blocklist is problematic.
  2. When the user tries to enable it, we should warn them that this blocklist is known to be breaking stuff.

Would this be just as simple as adding an information icon at the end of the problematic list name?
For example:

1Hosts Pro ℹ or 1Hosts Pro ⓘ

Then when the user hovers over the icon or hovers on the list name, it can display a message that says:

Warning:
[Insert brief summary with information the user should consider before enabling the list]

This would avoid using labels and color text, and just simply show that there's a little bit more that they should know. Also it would stand out to users because not every list will have the information icon. Or maybe a shield icon to go along with the AdGuard theme.

adgdnsiconwarning

Something like that but smaller.

Or maybe put a red advisory link next to the homepage link, and when they hover over "Advisory" it will display the message with the warning information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants