Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor reconcling and CRD #13

Open
AhmedGrati opened this issue Sep 10, 2022 · 0 comments
Open

Refactor reconcling and CRD #13

AhmedGrati opened this issue Sep 10, 2022 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@AhmedGrati
Copy link
Owner

AhmedGrati commented Sep 10, 2022

Description

The update of the CRD is basically meant to consider only adding attributes. Merging attributes won't be considered anymore.
The reason behind that is due to the fact that when we delete the CRD we could not roll back to the previous state of the merged attributes, since we don't store the state of these attributes.
Maybe it could be reconsidered in the future by implementing a more sophisticated solution but for now, it won't be supported.
In addition to that, attributes should be updated, in a way that we offer the user to have more customization over the attribute. e.g: he could specify whether to overwrite duplicate for the specific attribute or not.

spec:
  attributes:
  - annotations:
     - annot1: true
        overwriteDuplicate: false
@AhmedGrati AhmedGrati added the enhancement New feature or request label Sep 10, 2022
@AhmedGrati AhmedGrati self-assigned this Sep 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant