From 509e024b0a538ec468bdf470f224ae933d3c731a Mon Sep 17 00:00:00 2001
From: Volodymyr Shvydkyi <volodymyr.shvydkyi@supply.one>
Date: Tue, 2 Jul 2024 15:04:29 +0300
Subject: [PATCH 1/2] Fix picture selector behavior

---
 .../alchemy_admin/picture_selector.js         | 22 ++++++-
 .../alchemy/admin/pictures/index.html.erb     | 10 ---
 .../alchemy_admin/picture_selector.spec.js    | 63 +++++++++++++++++++
 3 files changed, 82 insertions(+), 13 deletions(-)
 create mode 100644 spec/javascript/alchemy_admin/picture_selector.spec.js

diff --git a/app/javascript/alchemy_admin/picture_selector.js b/app/javascript/alchemy_admin/picture_selector.js
index dace00271f..f3938b4ad3 100644
--- a/app/javascript/alchemy_admin/picture_selector.js
+++ b/app/javascript/alchemy_admin/picture_selector.js
@@ -4,20 +4,36 @@ import { on } from "alchemy_admin/utils/events"
  * Multiple picture select handler for the picture archive.
  */
 export default function PictureSelector() {
+  const selectAllButton = document.querySelector("#select_all_pictures")
   const selectedItemTools = document.querySelector(".selected_item_tools")
   const checkedInputs = () =>
     document.querySelectorAll("#picture_archive input:checked")
 
+  on("click", ".toolbar_buttons", "a#select_all_pictures", (event) => {
+    event.preventDefault()
+
+    selectAllButton.classList.toggle("active")
+
+    const state = selectAllButton.classList.contains("active")
+
+    document
+      .querySelectorAll(".picture_tool.select input[type='checkbox']")
+      .forEach(function (checkbox) {
+        checkbox.checked = state
+        checkbox.closest(".picture_thumbnail").classList.toggle("active", state)
+      })
+
+    selectedItemTools.classList.toggle("hidden", !state)
+  })
+
   // make the item toolbar visible and show the checkbox also if it is not hovered anymore
   on("change", ".picture_tool.select", "input", (event) => {
-    selectedItemTools.style.display =
-      checkedInputs().length > 0 ? "block" : "none"
+    selectedItemTools.classList.toggle("hidden", checkedInputs().length === 0)
 
     const parentElementClassList = event.target.parentElement.classList
     const checked = event.target.checked
 
     parentElementClassList.toggle("visible", checked)
-    parentElementClassList.toggle("hidden", !checked)
   })
 
   // open the edit view in a dialog modal
diff --git a/app/views/alchemy/admin/pictures/index.html.erb b/app/views/alchemy/admin/pictures/index.html.erb
index a73d23d87c..c25c2f5420 100644
--- a/app/views/alchemy/admin/pictures/index.html.erb
+++ b/app/views/alchemy/admin/pictures/index.html.erb
@@ -89,16 +89,6 @@
   <script type="text/javascript" charset="utf-8">
     $(function() {
       Alchemy.pictureSelector();
-      $('#select_all_pictures').on('click', function(e) {
-        $(this).toggleClass("active")
-        $('.picture_tool.select :checkbox')
-          .prop('checked', function(_i, val) { return !val })
-          .closest(".picture_thumbnail")
-          .toggleClass("active");
-        e.preventDefault;
-        $(".selected_item_tools").toggleClass("hidden")
-        return false;
-      });
       $('#picture_archive').on("click", ".thumbnail_background", function(event) {
         var url = $(this).attr('href');
         var overlay = new Alchemy.ImageOverlay(url);
diff --git a/spec/javascript/alchemy_admin/picture_selector.spec.js b/spec/javascript/alchemy_admin/picture_selector.spec.js
new file mode 100644
index 0000000000..246de0e797
--- /dev/null
+++ b/spec/javascript/alchemy_admin/picture_selector.spec.js
@@ -0,0 +1,63 @@
+import PictureSelector from "alchemy_admin/picture_selector"
+
+describe("PictureSelector", () => {
+  beforeEach(() => {
+    document.body.innerHTML = `
+      <div class="toolbar_buttons">
+        <a id="select_all_pictures"></a>
+      </div>
+      <div class="selected_item_tools hidden"></div>
+      <div id="picture_archive">
+        <div class="picture_thumbnail">
+          <span class="picture_tool select">
+            <input type="checkbox" name="picture_ids[]" id="checkbox_1" value="1">
+          </span>
+        </div>
+        <div class="picture_thumbnail">
+          <span class="picture_tool select">
+            <input type="checkbox" name="picture_ids[]" id="checkbox_2" value="1">
+          </span>
+        </div>
+      </div>
+    `
+
+    PictureSelector()
+  })
+
+  it("selects/unselects all images and toggles selection toolbar visibility", () => {
+    const selectAllButton = document.querySelector("#select_all_pictures")
+    const checkboxOne = document.querySelector("#checkbox_1")
+    const checkboxTwo = document.querySelector("#checkbox_2")
+    const selectionToolbar = document.querySelector(".selected_item_tools")
+
+    selectAllButton.click()
+
+    expect(selectAllButton.classList.contains("active")).toBeTruthy()
+    expect(selectionToolbar.classList.contains("hidden")).toBeFalsy()
+    expect(checkboxOne.checked).toBeTruthy()
+    expect(checkboxTwo.checked).toBeTruthy()
+
+    selectAllButton.click()
+
+    expect(selectAllButton.classList.contains("active")).toBeFalsy()
+    expect(selectionToolbar.classList.contains("hidden")).toBeTruthy()
+    expect(checkboxOne.checked).toBeFalsy()
+    expect(checkboxTwo.checked).toBeFalsy()
+  })
+
+  it("toggles selection toolbar visibility when one image is selected/unselected", () => {
+    const selectionToolbar = document.querySelector(".selected_item_tools")
+    const checkboxParent = document.querySelector(".picture_tool")
+    const checkbox = document.querySelector("#checkbox_1")
+
+    checkbox.click()
+
+    expect(selectionToolbar.classList.contains("hidden")).toBeFalsy()
+    expect(checkboxParent.classList.contains("visible")).toBeTruthy()
+
+    checkbox.click()
+
+    expect(selectionToolbar.classList.contains("hidden")).toBeTruthy()
+    expect(checkboxParent.classList.contains("visible")).toBeFalsy()
+  })
+})

From 42374ed962c233e62cf3de2a278dd7bb5d6be2e0 Mon Sep 17 00:00:00 2001
From: Volodymyr Shvydkyi <volodymyr.shvydkyi@supply.one>
Date: Tue, 2 Jul 2024 15:32:53 +0300
Subject: [PATCH 2/2] Refactor to fix codeclimate issue

---
 .../alchemy_admin/picture_selector.js         | 38 ++++++++++++-------
 1 file changed, 25 insertions(+), 13 deletions(-)

diff --git a/app/javascript/alchemy_admin/picture_selector.js b/app/javascript/alchemy_admin/picture_selector.js
index f3938b4ad3..3088efff26 100644
--- a/app/javascript/alchemy_admin/picture_selector.js
+++ b/app/javascript/alchemy_admin/picture_selector.js
@@ -1,13 +1,34 @@
 import { on } from "alchemy_admin/utils/events"
 
+function toggleCheckboxes(state) {
+  document
+    .querySelectorAll(".picture_tool.select input[type='checkbox']")
+    .forEach((checkbox) => {
+      checkbox.checked = state
+      checkbox.closest(".picture_thumbnail").classList.toggle("active", state)
+    })
+}
+
+function checkedInputs() {
+  return document.querySelectorAll("#picture_archive input:checked")
+}
+
+function editMultiplePicturesUrl(href) {
+  const searchParameters = new URLSearchParams()
+  checkedInputs().forEach((entry) =>
+    searchParameters.append(entry.name, entry.value)
+  )
+  const url = href + "?" + searchParameters.toString()
+
+  return url
+}
+
 /**
  * Multiple picture select handler for the picture archive.
  */
 export default function PictureSelector() {
   const selectAllButton = document.querySelector("#select_all_pictures")
   const selectedItemTools = document.querySelector(".selected_item_tools")
-  const checkedInputs = () =>
-    document.querySelectorAll("#picture_archive input:checked")
 
   on("click", ".toolbar_buttons", "a#select_all_pictures", (event) => {
     event.preventDefault()
@@ -16,12 +37,7 @@ export default function PictureSelector() {
 
     const state = selectAllButton.classList.contains("active")
 
-    document
-      .querySelectorAll(".picture_tool.select input[type='checkbox']")
-      .forEach(function (checkbox) {
-        checkbox.checked = state
-        checkbox.closest(".picture_thumbnail").classList.toggle("active", state)
-      })
+    toggleCheckboxes(state)
 
     selectedItemTools.classList.toggle("hidden", !state)
   })
@@ -40,11 +56,7 @@ export default function PictureSelector() {
   on("click", ".selected_item_tools", "a#edit_multiple_pictures", (event) => {
     event.preventDefault()
 
-    const searchParameters = new URLSearchParams()
-    checkedInputs().forEach((entry) =>
-      searchParameters.append(entry.name, entry.value)
-    )
-    const url = event.target.href + "?" + searchParameters.toString()
+    const url = editMultiplePicturesUrl(event.target.href)
 
     Alchemy.openDialog(url, {
       title: event.target.title,