Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small issues before releasing on jpro.one #1

Open
FlorianKirmaier opened this issue Apr 30, 2019 · 1 comment
Open

Small issues before releasing on jpro.one #1

FlorianKirmaier opened this issue Apr 30, 2019 · 1 comment

Comments

@FlorianKirmaier
Copy link

Hi @AlmasB

I've got some notes about the project:

  • To Work as a JPro, it must be possible, to instantiate the application multiple times. Currently, I get the following exception when starting the application twice:
java.lang.IllegalStateException: Logger already configured
        at com.almasb.sslogger.Logger$Companion.configure(Logger.kt:29)
        at com.almasb.sslogger.Logger.configure(Logger.kt)
        at com.almasb.fxgl.app.GameApplication.initLogger(GameApplication.java:123)
        at com.almasb.fxgl.app.GameApplication.customLaunch(GameApplication.java:82)

I thinks that's something you have to fix inside of FXGL.

  • Is it possible to skip the first intro? It currently doesn't perform very well. What are you using in it, which might cause the performance issue?
  • This demo is good as a HelloWorld, because the code is quite short, but for the demo-page I think something a bit more complex would work better.
@AlmasB
Copy link
Owner

AlmasB commented May 3, 2019

Hi @FlorianKirmaier

Many thanks for this.

  1. I will carefully consider multiple instantiations, as it is not allowed by design in FXGL. By far this is the most difficult fix.

  2. Yes, though I would rather fix the performance issue. I'll have a look at it. Behind it all, there is a lot of small ImageView objects, perhaps they are the bottleneck. Will let you know after I've done some playing.

  3. We've got a couple of interesting-looking demos. Once the above fixes are known, I can start looking at that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants