Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to decrease parent or child lineage level #1171

Open
1 task done
thewhitetulip opened this issue May 30, 2024 · 4 comments
Open
1 task done

Ability to decrease parent or child lineage level #1171

thewhitetulip opened this issue May 30, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@thewhitetulip
Copy link
Contributor

thewhitetulip commented May 30, 2024

Describe the feature

Currently when we look at the lineage of child or parent models, then we can not reduce them. We can keep adding parent or child tables, but we can't reduce them. In DBT cloud, we have a input bar where it defaults to 3+model+3 and we can keep changing on the left and right hand side to get the lineage which we want. I think it would help to have this feature in this plugin.

Right now, we only have the feature of adding child or parent models in the newlineagepanel. I would like to add a feature of reducing them. DBT Cloud gives you the ability to do this.

Describe alternatives you've considered

No response

Who will benefit?

Those who want to look at upstream or downstream lineage only

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
@thewhitetulip thewhitetulip added the enhancement New feature or request label May 30, 2024
@thewhitetulip thewhitetulip changed the title Ability to see lineage like +model or model+ Ability to decrease parent or child lineage level May 30, 2024
@thewhitetulip
Copy link
Contributor Author

@mdesmet @anandgupta42

@anandgupta42
Copy link
Contributor

@thewhitetulip We had started working on it but never got to finish it : #785

We may need to handle some tricky corner cases for node-level collapse. However, collapse should be easy to implement level-wise. Please share your view on how you plan to implement it.

Thanks once again for offering to contribute.

@thewhitetulip
Copy link
Contributor Author

thewhitetulip commented Jun 12, 2024

@anandgupta42 I need to check on how to implement. I am totally new to JS! I'll have a look and let you know.
also for reference, do I need to pick up from #785?

@thewhitetulip
Copy link
Contributor Author

@anandgupta42 How about instead of the current settings display of two buttons, we provide a textbox as an input and default it to 3+model+3 and then when people update either the upstream or the downstream then we redraw the lineage. that'll do away with the collapsing problem?

I mean this is how dbt cloud UI does it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants