Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigator footprints list manipulation is very complicated #161

Open
Anusien opened this issue Dec 15, 2021 · 0 comments
Open

Investigator footprints list manipulation is very complicated #161

Anusien opened this issue Dec 15, 2021 · 0 comments
Labels
fixit Purely technical fixes that don't affect gameplay

Comments

@Anusien
Copy link
Owner

Anusien commented Dec 15, 2021

The Investigator has this Footprint class. It manages its own lifecycle by hooking into the Investigator class. It has a lot of logic to add itself to the list of footprints when created and remove itself when it's aged out. This ends up with some complicated logic to iterate through the list of footprints where the for loop has to manage its own index variable and move it backward because some functions will remove themselves.

We should clean all this up so the code that adds and removes things from the list also controls insertion. I suspect this moves all the logic to AddPrints and makes Footprint way more simple.

@Anusien Anusien added the fixit Purely technical fixes that don't affect gameplay label Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixit Purely technical fixes that don't affect gameplay
Projects
None yet
Development

No branches or pull requests

1 participant