Generate Impostor Modifiers First #171
Conversation
You generate your modifer impostor after the globals, so that if a global goes on an impostor, it will not be able to have the modifier impostor if you have 2 for 2 impostors it will create a conflict example, I put the 2 modifiers impostor at 100% and I have 2 impostors in the game, one of them is designated button barry, only one of the 2 imposters modifiers will be present while I expect to have both.
| @@ -892,6 +897,15 @@ public static void Prefix([HarmonyArgument(0)] ref Il2CppReferenceArray<GameData | |||
|
|
|||
| if (Check(CustomGameOptions.GrenadierOn)) | |||
| ImpostorRoles.Add((typeof(Grenadier), CustomRPC.SetGrenadier, CustomGameOptions.GrenadierOn)); | |||
| #endregion | |||
| #region Impostor Modifiers //just for better organization | |||
| if (Check(CustomGameOptions.AnthropomancerOn)) | |||
There was a problem hiding this comment.
Anthropomancer isn't an impostor-only modifier
| @@ -172,19 +172,24 @@ private static void GenEachRole(List<GameData.PlayerInfo> infected) | |||
| Role.Gen<Role>(typeof(Crewmate), executioner, CustomRPC.SetExecutioner); | |||
| } | |||
|
|
|||
| var canHaveModifier = PlayerControl.AllPlayerControls.ToArray().ToList(); | |||
| List<PlayerControl> canHaveModifier = PlayerControl.AllPlayerControls.ToArray().ToList().FindAll(player => player.Is(Faction.Impostors)); | |||
There was a problem hiding this comment.
This removing and adding from the canHaveModifier list feels very brittle and easy to mess up in the future. You've found a real bug, but I don't like this fix. I think we need to find a better method of bookkeeping.
Partially this is because the existing code is a bit messy. Probably the right answer is to do the crewmates and the impostors separately, and combine those lists. I suspect part of the key is to create separate lists and combine rather than have a single list and add to it. I dislike modifying the list in this way for the same reason that I like final variables; you can look at a line of code and easily run backward through the code in your head and figure out what happened to get there.
You generate your modifer impostor after the globals, so that if a global goes on an impostor, it will not be able to have the modifier impostor if you have 2 for 2 impostors it will create a conflict example, I put the 2 modifiers impostor at 100% and I have 2 impostors in the game, one of them is designated button barry, only one of the 2 imposters modifiers will be present while I expect to have both.