Split options packet into multiple packets #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to the huge amount of options, the SyncCustomSettings packet is getting extremely large. This patch takes two measures to correct this 1. By using StartRpcImmediately it'll not lump in this packet with around ~100 bytes of other data. This moves the issue 20 options down the road. 2. By splitting the packet in multiple chunks of 1000 bytes, every packet stays well beloy the ~1472 byte limit. This prevents the issue from appearing again. This change needs the first change though, otherwise both chunks will be lumped in the same packet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the huge amount of options, the SyncCustomSettings packet is
getting extremely large. This patch takes two measures to correct this
By using StartRpcImmediately it'll not lump in this packet with
around ~100 bytes of other data. This moves the issue 20 options down
the road.
By splitting the packet in multiple chunks of 1000 bytes, every
packet stays well beloy the ~1472 byte limit. This prevents the issue
from appearing again. This change needs the first change though,
otherwise both chunks will be lumped in the same packet.
By miniduikboot