Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove classSourcedId in Result #80

Open
xchopin opened this issue May 3, 2019 · 0 comments
Open

Remove classSourcedId in Result #80

xchopin opened this issue May 3, 2019 · 0 comments

Comments

@xchopin
Copy link
Member

xchopin commented May 3, 2019

Result objects contain a field named "classSourcedId", there is a problem about this.

Context

ClassSourcedId is an attribute of the LineItem objects.

Following the OneRoster structure, a Result is linked to a LineItem and a User.

When creating a Result object, the API expects you to use the following HTTP POST route /classes/:id/results

The value of classSourcedId is gotten by using the URI and then added to the Result object.

Structure issue

First, the used route is already not "OneRoster compatible" since there is no links between Results and Classes (it should have been something like /lineitems/:id/results )

The classSourcedId value is already supposed to be in the LineItem object (following the OneRoster structure).

Production issue

If you PATCH a LineItem and you update its classSourcedId it is not gonna update all the Result objects that are linked to this LineItems, which means this value is going to be wrong for all these objects.

What do you think about it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant