Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go Regexp repetition limit. #1

Open
2 of 4 tasks
ArmanHZ opened this issue Sep 29, 2023 · 2 comments
Open
2 of 4 tasks

Go Regexp repetition limit. #1

ArmanHZ opened this issue Sep 29, 2023 · 2 comments

Comments

@ArmanHZ
Copy link
Owner

ArmanHZ commented Sep 29, 2023

Following hash regexp rules exceed the 1000 repetition limit set by Golang:

  • {"GRUB 2", 7200, "", false}
  • {"Microsoft MSTSC(RDP-File)", -1, "", false}
  • {"1Password(Agile Keychain)", 6600, "", false}
  • {"Android FDE ≤ 4.3", 8800, "fde", false}

Another detection mechanism is needed for these.

@CPunch
Copy link
Collaborator

CPunch commented Sep 29, 2023

as discussed in an off-site discussion it'd make sense to have a closure callback instead of the raw regex. this would allow for more complicated rules, and allow us to handspin the detection for the regexps that exceed the 1000 repetition limit :D

@CPunch CPunch closed this as completed in ce4a916 Oct 4, 2023
@CPunch CPunch reopened this Oct 4, 2023
@CPunch
Copy link
Collaborator

CPunch commented Oct 4, 2023

GRUB 2 hashes are now supported; see ce4a916

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants