This repository has been archived by the owner on Jun 13, 2020. It is now read-only.
Reorder AppRole.map_val parameters #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
map_val is only used by AppRole.__init__, and the latter passes dest dict as the first argument [0], while map_val has src as the first parameter [1]. It makes sense to fix map_val signature and put dest on the first place. This way we change only one line and at the same time make it to follow traditions of some other languages [2]. [0] https://github.com/Autodesk/aomi/blob/028d75307a54f69b27a53a0a349910af7e3aac47/aomi/model/auth.py#L184-L194 [1] https://github.com/Autodesk/aomi/blob/028d75307a54f69b27a53a0a349910af7e3aac47/aomi/model/auth.py#L163-L173 [2] http://lemire.me/blog/2016/09/06/function-signature-how-do-you-order-parameters/
|
Hmm this is part of the code which could really use some more test coverage... I'll take a look tonight... |
ericfode
approved these changes
Aug 3, 2017
I've just checked, and, yes, bug exists and this change fixes it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AppRole.map_valis only used byAppRole.__init__, and the latter passesdestdict as the first argument, whilemap_valhassrcas the first parameter.It makes sense to fix
map_valsignature and putdeston the first place. This way we change only one line and at the same time make it to follow traditions of some other languages.I noticed it fixing #126, but haven't checked if it's really a bug yet.
TBU.