Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop the monitoring stack from the up phase #195

Open
msimonin opened this issue Sep 6, 2017 · 5 comments
Open

Drop the monitoring stack from the up phase #195

msimonin opened this issue Sep 6, 2017 · 5 comments

Comments

@msimonin
Copy link
Contributor

msimonin commented Sep 6, 2017

Kolla can deploy influxdb + grafana + collectd + telegraf. The agents are configurable through the node_custom_config parameter.

@rcherrueau, should we get rid of the corresponding roles in the up phase ?

Pros:

Pros or Cons (depends)

  • configuration will be done through node_custom_config mecanism

Cons

@rcherrueau
Copy link
Member

Not sure how to do that. In the actual implementation activating monitoring is as simple as enable_monitoring: yes and I would appreciate that it stay like that (leveraging kolla or not). Btw, the keynote at Cloud Day's this morning was from the CEO of CloudScreen and he gave really good feedback on prometheus.

@msimonin
Copy link
Contributor Author

msimonin commented Sep 7, 2017

I had a quick look :

kolla:
  enable_telegraf: yes
  enable_collectd: yes
  enable_grafana: yes
  enable_influxdb: yes

This is obviously not as simple (at least in the current status of Kolla and EnOS). But we could keep enable_monitoring: yes|no and generate those variables at runtime if needed.

I see some advantages nevertheless :

  • less code to maintain
  • an up-to-date code
  • it would be easy to use a dedicated network for all the monitoring traffic (this requires a small fix in Kolla)

Let's iterate on the pros and cons :)

@rcherrueau
Copy link
Member

This is a nice list of pros 👍. Let's do this!

@msimonin
Copy link
Contributor Author

I've put the list at the top level

@msimonin
Copy link
Contributor Author

just added a cons

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants