-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new resumevideos tag #18
base: master
Are you sure you want to change the base?
Conversation
A "resumevideos" tag ... similarly to recentvideos, the resumevideos shows a consolidated list of resumable video content (movies and episodes you have started watching but haven't completed)
for "resumevideos" functionality
for "resumevideos" functionality
rather have it you squash to one commit using some git client. having it like this ruins proper history maintenance |
Please note - these updates work as expected in adding a resumevideos tag, but there is a small bug I would like to request assistance with. When the number of resumable episodes is greater than one, there is an issue with the displayed art/info - for instance, if there are 3 resumable episodes, the list will display 3 but all 3 will be the same episode. I think the issue lies somewhere in the parse_tvshows function but I am not sure how to fix it. |
Hi Martijn, I am sorry I am not sure what you mean (or how to do that)....I have just started with GitHub today in order to request this added functionlity.. |
I dont see the point of adding resumable episodes. The functionality is already there in recommended episodes so this seem superfluous to me. I dont think generally speaking people have whole lists worth of resumable episodes, they are 20-45 min after all. Squashing is done by git rebase -i HEAD~3 (in this case). |
Removes the resumeepisodes (including retrieving the data), and instead uses the recommended episode data to build the resumevideos list. Also changed the resumevideos to sort by lastplayed, so that the most recently stopped video appears first.
I personally found it useful to have a single "resumable videos" list, it's a bit different from the recommended episodes one, but it's your call of course. And about git rebase -i HEAD~3 - where exactly does one enter that? Can it be done through this website or is that only for git clients? |
Remove resumeepisodes, use existing data for resumevideos
The rebase command needs to be done from a command line on a system with the git tools installed, with the command lines directory being the git repositories dierectory. As you've now pulled in two additional commits the command needs to be git rebase -i HEAD~5 (You're "rebase"ing (setting what commit Git history is based on) ”-i"nteractively, from "HEAD" (the current state) the last ”~5" commits - or, in English, your rewritting the Git history of the last five commits.) You'll be presented wih two text editors, one after the other (on *nix, by default these will be vi, on Windows presumably notepad). On the first, mark all but the first commit as 's' or 'squash', and give the first commit a descriptive title of the functional changes you're making like 'Add resumevidoes'. Once you've saved that, on the second window delete the commit comments from all but the first commit, and ensure the comments are descriptive and relevant. You'll then need to force a git push git push -f Which will update your git and show the new - single commit - here. There are git clients which can do this all graphically. tortoisegit on windows, for example. |
…against it: only show the latest episode of a tv show instead of showing multiple
This would add "Resume Watching" functionality to the homescreen...
The recommendedmovies tag retrieves only the resumable movies, which is the desired result.
But the recommendedepisodes tag retrieves "tv shows in progress"...these are not only episodes you have started watching and haven't finished, but all tv shows with remaining unwatched episodes (this is great for general recommendation purposes but not resume purposes).
Similarly to the recentvideos tag, the resumevideos tag would provide a consolidated view of resumable content, to easily continue with movies and episodes where you have left off previously.