Frontend android back hashrouter #2705
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the BrowserRouter is needlessly complicated, we don't need the browser to make a new "request" when we route to a different page. Getting this to work is especially difficult in iOS, where the file path to index.html is loaded in the webview, and routing to e.g. `/account-summary' fails because the absolute filepath `/account-summary` does not exist and is outside the app folder sandbox. Using the hash router instead, where the app path is tracked behind the `#` (e.g. index.html#/account-summary) is more appropriate and easier to handle.
This should replace native Android back behavior with either going back in the webview or closing the app. This is using the native goBack method but it seems that the app only goes back to account summary. This could probably be improved later and seems already useful with just going back to summary. On the account summary it cannot go back any further so it will trigger the old do-you-want-to-quit alert. Replaced deprecated onBackPressed override.
thisconnect
force-pushed
the
frontend-android-back-hashrouter
branch
from
508f7dd
to
7925b04
Compare
|
rebased |
thisconnect
force-pushed
the
frontend-android-back-hashrouter
branch
from
3e1c72f
to
7925b04
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.