Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add delimiters around data spaces incoming automatically #147

Open
riftEmber opened this issue Sep 22, 2021 · 2 comments
Open

Add delimiters around data spaces incoming automatically #147

riftEmber opened this issue Sep 22, 2021 · 2 comments
Assignees
@riftEmber

Comments

@riftEmber
Copy link
Member

Can be accomplished by a regex which finds potential identifiers, then delimits them if they match a list of data spaces
@riftEmber riftEmber self-assigned this Sep 22, 2021
@riftEmber
Copy link
Member Author

Working on branch delimit-data-spaces

riftEmber added a commit that referenced this issue Oct 6, 2021
@riftEmber
Add incomplete implementation of data space delimiting function #147
e8bd2c2
riftEmber added a commit that referenced this issue Oct 13, 2021
@riftEmber
Add and use data space delimiting function #147
a4cc7ca
riftEmber added a commit that referenced this issue Oct 13, 2021
@riftEmber
Automatically perform delimiting in addStmt #147
7eb985c 
Includes modifying tests to work with this
riftEmber added a commit that referenced this issue Oct 13, 2021
@riftEmber
Fix treatment of return values, avoid cases of double delimiting #147
8266290 
Also fix some incorrect tests, both with incorrect delimiting and
missing data space declarations.
@riftEmber riftEmber assigned shuai-yang and unassigned shuai-yang Oct 13, 2021
riftEmber added a commit that referenced this issue Oct 13, 2021
@riftEmber
Add and use data space delimiting function #147
2a455d4
riftEmber added a commit that referenced this issue Oct 13, 2021
@riftEmber
Automatically perform delimiting in addStmt #147
cc8b18d 
Includes modifying tests to work with this
riftEmber added a commit that referenced this issue Oct 13, 2021
@riftEmber
Fix treatment of return values, avoid cases of double delimiting #147
fa11393 
Also fix some incorrect tests, both with incorrect delimiting and
missing data space declarations.
riftEmber added a commit that referenced this issue Oct 13, 2021
@riftEmber
Fix missing delimiting in appendComputation #147
7aec790
riftEmber added a commit that referenced this issue Oct 13, 2021
@riftEmber
Fix missing delimiting in appendComputation and for unroll/reroll #147
1317173
riftEmber added a commit that referenced this issue Oct 13, 2021
@riftEmber
Add to data space delimiting test #147
b76267a
@riftEmber
Copy link
Member Author

riftEmber commented Oct 13, 2021 •
edited
Loading

Done and merged. New assumptions when using Computation API:

  • You should no longer ever have to manually delimit anything, except in extremely limited testing cases.
  • Data spaces used in a statement must be added to the Computation (with addDataSpace or a method that calls it like addParameter) before the statement is added to the Computation (with addStmt).
  • Stmts may only be added via addStmt, because it will handle delimiting them (although it also seems to handle several other things, so this assumption was kind of already in place).
  • Automatic delimiting only occurs upon a Stmt being added to a Computation. This makes sense because delimiting is only needed for a Stmt that exists as part of a Computation.

@riftEmber riftEmber reopened this Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@riftEmber riftEmber

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shuai-yang @riftEmber