Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Execution Schedules for Dynamically-added statements #154

Open
Aaron3154518 opened this issue Sep 28, 2021 · 0 comments
Open

Fix Execution Schedules for Dynamically-added statements #154

Aaron3154518 opened this issue Sep 28, 2021 · 0 comments
Assignees

Comments

@Aaron3154518
Copy link

We have the following statement types which are added dynamically (not by the user of spf-ie):

  • appendComputation pass-by-value parameter statements
  • phi nodes
  • array unrolling/rerolling
    The first type already inserts itself correctly into the execution schedule. Phi nodes and array statements, however, just adopt their successor node's execution schedule. We need to change this. This means not only updating the phi/array statement's execution schedules, but also that of all future statements.

Function header:
void adjustExecutionSchedules()
It will be called in finalize(). It MUST be called before padExecutionSchedules() so that the Compose() calls can generate correct Relations. Due to this, padExecutionSchedules() is being moved to finalize() where it will be called after adjustExecutionSchedules().

macdonaldlowe added a commit that referenced this issue Sep 28, 2021
Fixed some errors in geoac_codegen_driver
Added finalize() calls in tutorial files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants