Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Commit

Permalink
increase strict TS compat
Browse files Browse the repository at this point in the history
  • Loading branch information
forman committed Feb 28, 2020
1 parent b1cdc6d commit 0aca34e
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 4 deletions.
5 changes: 5 additions & 0 deletions ISSUES.md
Original file line number Diff line number Diff line change
Expand Up @@ -66,4 +66,9 @@
* Replace `Object.assign({}, a, b, ...)` calls by `{...a, ...b, ...}`.

- App logic:
* When authentication fails we always say "Wrong username or password", but reasons may be very different,
e.g. CORS stuff (TypeError), 40x and 50x errors
* Getting message "Opps! Connection ... closed" when logging out.
* Electron main, remote mode: Only quit after we have successfully logged out OR after timeout
* When going back from first screen, `webAPIConfig` will be the one from CateHub. To fix this
we need `interface { local: WebAPIConfig, remote: WebAPIConfig }`
6 changes: 3 additions & 3 deletions src/common/array-diff.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import * as assert from './assert';
import deepEqual = require('deep-equal');
import deepEqual from 'deep-equal';

type ObjectWithId = { id: any; }

Expand Down Expand Up @@ -49,9 +49,9 @@ export interface ArrayAction<T extends ObjectWithId> {
* Signature: (element1, element2) => any
* @returns {ArrayAction<T>[]} An array of actions to be performed to make oldArray equal to newArray.
*/
export function arrayDiff<T extends ObjectWithId>(oldArray: T[], newArray: T[], computeChange?): ArrayAction<T>[] {
export function arrayDiff<T extends ObjectWithId>(oldArray: T[], newArray: T[], computeChange?: (e1: any, e2: any) => any): ArrayAction<T>[] {

const actions = <ArrayAction<T>[]>[];
const actions = [] as ArrayAction<T>[];
const currentArray = oldArray.slice();

// REMOVE first, so we have less actions afterwards
Expand Down
2 changes: 1 addition & 1 deletion src/renderer/reducers.ts
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ import {
INITIAL_SESSION_STATE
} from './initial-state';
import { NEW_CTX_OPERATION_STEP_DIALOG_ID } from './containers/operation-step-dialog-ids';
import deepEqual = require('deep-equal');
import deepEqual from 'deep-equal';

// Note: reducers are unit-tested through actions.spec.ts

Expand Down

0 comments on commit 0aca34e

Please sign in to comment.