Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve Dependabot alert on ws in package-lock.json #662

Closed
jsjiang opened this issue Jul 1, 2024 · 4 comments
Closed

Resolve Dependabot alert on ws in package-lock.json #662

jsjiang opened this issue Jul 1, 2024 · 4 comments

Comments

@jsjiang
Copy link
Contributor

jsjiang commented Jul 1, 2024

Dependabot successfully created a pull request for this alert. Review [the pull request(https://github.com//pull/656), test the gulp build tool and EZID UI, merge pull request if there are no issues.

Develop a procedure to handle following situations

  • Dependabot successfully created a pull request
  • Dependabot failed to create a pull request
  • Update package.json and package-lock.json manually
@jsjiang
Copy link
Contributor Author

jsjiang commented Jul 8, 2024

Procedure:

  • review code to see if EZID UI uses the affected package
    • if yes, take quick actions
    • if no, this means the package is used by the build tool. Dismiss the alert or upgrade the affected package
  • upgrade affected package
    • option 1: use GitHub created pull request
    • option 2: run npm update command to upgrade the affected package
  • validate upgrade
    • run gulp command to see if there are issues with the "EZID UI Library" at http://localhost:3000
    • run gulp build to see if there are issues with building css, JavaScript and image files
    • test EZID UI
    • commit changes (outputs from gulp build) if there are any

@jsjiang
Copy link
Contributor Author

jsjiang commented Jul 8, 2024

Reviewed EZID code:

  • ws (WebSocket) - Not used
  • engine.io-client - Not used
  • engine.io - not used
  • socket.io-adapter - not used

@adambuttrick
Copy link

Part of #663.

@jsjiang
Copy link
Contributor Author

jsjiang commented Jul 15, 2024

Resolved - see release v3.2.14 resolve Dependabot alert

@jsjiang jsjiang closed this as completed Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants