Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor parse_labels() to remove return_stripped_text_flag parameter #124

Open
4 of 5 tasks
ezraporter opened this issue Feb 6, 2023 · 0 comments
Open
4 of 5 tasks
Labels
backlog not to be worked on now enhancement New feature or request refactor

Comments

@ezraporter
Copy link
Collaborator

Currently parse_labels() takes a return_stripped_text_flag argument that, if TRUE, returns a flag indicating whether or not parse_labels() altered label text during parsing by stripping HTML/field embedding logic.

This complexity was introduced in #118 to allow check_parsed_labels() to add a message indicating that the labels were altered. Ideally check_parsed_labels() could produce the correct message without parse_labels() needing to pass a flag around but this would take additional refactoring of how we handle applying labels.

Checklist

  • The issue is atomic
  • The issue description is documented
  • The issue title describes the problem succinctly
  • Developers are assigned to the issue
  • Labels are assigned to the issue
@ezraporter ezraporter added enhancement New feature or request backlog not to be worked on now refactor labels Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog not to be worked on now enhancement New feature or request refactor
Projects
None yet
Development

No branches or pull requests

1 participant