Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine distill_*_table functions #61

Open
3 of 5 tasks
ezraporter opened this issue Oct 28, 2022 · 0 comments
Open
3 of 5 tasks

Combine distill_*_table functions #61

ezraporter opened this issue Oct 28, 2022 · 0 comments
Labels
backlog not to be worked on now refactor

Comments

@ezraporter
Copy link
Collaborator

Feature Request Description

We currently have four functions that do the bulk of redcap processing work. clean_redcap() has distill_repeat_table() and distill_nonrepeat_table(). clean_redcap_long() has distill_repeat_table_long() and distill_nonrepeat_table_long(). There's a good amount of duplicated code between these helper functions.

Proposed Solution

Combine distill_repeat_table() and distill_nonrepeat_table() into a single distill_table(). Combine distill_repeat_table_long() and distill_nonrepeat_table_long() into a single distill_table_long(). This will reduce duplication without going so far as to mix our longitudinal and non-longitudinal processing together.

Checklist

  • The issue is atomic
  • The issue description is documented
  • The issue title describes the problem succinctly
  • Developers are assigned to the issue
  • Labels are assigned to the issue
@rsh52 rsh52 added the backlog not to be worked on now label Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog not to be worked on now refactor
Projects
None yet
Development

No branches or pull requests

2 participants