Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] Lock Blast DB Version #68

Open
marchoeppner opened this issue Apr 8, 2024 · 1 comment
Open

[Request] Lock Blast DB Version #68

marchoeppner opened this issue Apr 8, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@marchoeppner
Copy link

Hi,

I am not 100% sure that I am not misreading this, but in:
https://github.com/CVUA-RRW/FooDMe/blob/master/ressources/fetch_nt_blast.sh

it reads as if the script downloads directly out of https://ftp.ncbi.nlm.nih.gov/blast/db/

For the sake of reproducibility, I would suggest to change that to:

https://ftp.ncbi.nlm.nih.gov/blast/db/v5

to make sure that the database version is reproducible - it's always possible that NCBI releases a version 6, which would overwrite the contents in https://ftp.ncbi.nlm.nih.gov/blast/db/.

Cheers,
Marc

@marchoeppner marchoeppner added the enhancement New feature or request label Apr 8, 2024
@gregdenay
Copy link
Member

Hi Marc,

you are reading it correctly, this is a welcome enhancement. Thanks a lot for the feedback.
It should be noted however that this is the database format Version 5, NOT the content, database content is regulary expanded.

This script could use some improvement to ease the database update process too (it would now redownload the entire database, unless you kept the .tar archives). But I think the BLAST tools could (should) be used directly for this?

Do you want to submit a PR for this ?

Cheers
Greg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants