Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we allow skipping lint checks? #31

Open
binsee opened this issue Apr 20, 2022 · 1 comment
Open

Should we allow skipping lint checks? #31

binsee opened this issue Apr 20, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@binsee
Copy link
Member

binsee commented Apr 20, 2022

In some projects, lint is problematic. And it may not be repaired in a short time, then push will be block.

E.g. #29

It would be useful to have a SKIP_LINT=1 option to skip lint checks.

@huan
Copy link
Member

huan commented Apr 24, 2022

I think we can add an option for users to skip them.

However, if we use an environment variable to skip it, then I think it should follow the name conversion of the existing ones.

For example:

  1. NO_HOOK & NO_LINT will match, or
  2. SKIP_LINK & SKIP_HOOK will match.

Please feel free to create PRs to add your improvements, and also please don't forget to add the usage to our README as docs.

Thank you very much for your contribution!

@huan huan added the enhancement New feature or request label Apr 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants