Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GFS currently assumes contained Prognostics use same tendency shape as itself #60

Open
mcgibbon opened this issue Jul 12, 2018 · 2 comments
Open

GFS currently assumes contained Prognostics use same tendency shape as itself #60

mcgibbon opened this issue Jul 12, 2018 · 2 comments

Comments

@mcgibbon
Copy link
Member

Right now the GFS code makes the implicit assumption that all Prognostic objects wrapped by it will return tendencies with the same dimension ordering as itself. It shouldn't be making this assumption, meaning we'll have to write some more complex code to deal with getting tendencies.
@JoyMonteiro
Copy link
Member

Is this a priority? we could change this after the upcoming release.

@mcgibbon
Copy link
Member Author

It is a priority. This is a pretty substantial bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JoyMonteiro @mcgibbon