Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

even?, odd?, maybe others are underspec'd #70

Open
stanislowskij opened this issue Sep 17, 2024 · 0 comments
Open

even?, odd?, maybe others are underspec'd #70

stanislowskij opened this issue Sep 17, 2024 · 0 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers needs exploration Need to find more specific examples and narrow down the issue

Comments

@stanislowskij
Copy link
Collaborator

The current specs state that the argument should only be a number, not strictly an integer. This gives us a default error instead, which also has a misleading Babel message:

(s/fdef clojure.core/even?
  :args :babel.args/one-number)
(stest/instrument `clojure.core/even?)

after running (setup-exc):

babel.middleware=> (even? 1.2)
Expected an integer number, but a sequence 1.2 was given instead.

TODO: Find other cases

@stanislowskij stanislowskij added bug Something isn't working good first issue Good for newcomers needs exploration Need to find more specific examples and narrow down the issue labels Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers needs exploration Need to find more specific examples and narrow down the issue
Projects
None yet
Development

No branches or pull requests

2 participants