Skip to content
This repository has been archived by the owner on Jun 7, 2022. It is now read-only.

Wrappers should set their local address when connecting to the master #213

Open
juliarn opened this issue Oct 30, 2019 · 1 comment
Open

Wrappers should set their local address when connecting to the master #213

juliarn opened this issue Oct 30, 2019 · 1 comment
Assignees
@GiantTreeLP
Labels
bug Something isn't working done This issue has been dealt with and will be closed with the next pull request into master
Projects
Code quality 2.2.0

Comments

@juliarn
Copy link
Contributor

juliarn commented Oct 30, 2019 •
edited
Loading

The wrapper verification works through the comparison of the address of the connected wrapper and the address of the wrapper in the services.json.
If a server has multiple public ips, this can lead to issues when trying to connect to the master, because the wrapper doesn't set the local address when connecting to the master, so the ips might not be the same.
The wrapper should set the address in the config.yml as its local address.
@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label bug to this issue, with a confidence of 0.81. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@issue-label-bot issue-label-bot bot added the bug Something isn't working label Oct 30, 2019
@GiantTreeLP GiantTreeLP self-assigned this Nov 13, 2019
GiantTreeLP added a commit that referenced this issue Nov 20, 2019
@GiantTreeLP
Set the local address for the connection of the wrapper to the master
cb6e85e 
 to the one configured as the internal IP
 Closes #213
@GiantTreeLP GiantTreeLP added this to To do in Code quality via automation Mar 1, 2020
@GiantTreeLP GiantTreeLP moved this from To do to Done in Code quality Mar 1, 2020
@GiantTreeLP GiantTreeLP added the done This issue has been dealt with and will be closed with the next pull request into master label Mar 25, 2020
@GiantTreeLP GiantTreeLP added this to Done in 2.2.0 Apr 23, 2020
@byRoadrunner byRoadrunner moved this from Done to In progress in 2.2.0 May 9, 2020
@byRoadrunner byRoadrunner moved this from In progress to Done in 2.2.0 May 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@GiantTreeLP GiantTreeLP

Labels
bug Something isn't working done This issue has been dealt with and will be closed with the next pull request into master
Projects
No open projects
2.2.0
  
Done
Code quality
  
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@GiantTreeLP @juliarn