Skip to content
This repository has been archived by the owner on Jun 7, 2022. It is now read-only.

Rework handling of serverInstallablePlugins #254

Open
GiantTreeLP opened this issue Mar 26, 2020 · 3 comments
Open

Rework handling of serverInstallablePlugins #254

GiantTreeLP opened this issue Mar 26, 2020 · 3 comments
Assignees
Labels
done This issue has been dealt with and will be closed with the next pull request into master rework Some enhancements have to be made

Comments

@GiantTreeLP
Copy link
Member

Currently plugins which can be hosted on the wrapper, the master or any network resource are loaded rather crudely with a lot of smelly, duplicated and error-prone code.

This issue is a marker for the project and acts as a hub for discussion about this feature.

Any changes to the current implementation of serverInstallablePlugins should not result in any change to the configuration or overarching API.

@GiantTreeLP GiantTreeLP self-assigned this Mar 26, 2020
@GiantTreeLP GiantTreeLP added this to To do in Code quality via automation Mar 26, 2020
@GiantTreeLP GiantTreeLP added the rework Some enhancements have to be made label Mar 26, 2020
@GiantTreeLP GiantTreeLP moved this from To do to In progress in Code quality Mar 26, 2020
@TheMeinerLP
Copy link
Contributor

The plan was to remove in the future the feature or rework with all of the template system.

@GiantTreeLP
Copy link
Member Author

This can be thought of an intermediate step to improve code quality so that later we can pull in the good code.
Maybe you can incorporate this into #248

@TheMeinerLP
Copy link
Contributor

I can do this, but i make that in a extra pull request. That's the better way

@GiantTreeLP GiantTreeLP added the done This issue has been dealt with and will be closed with the next pull request into master label Apr 16, 2020
@GiantTreeLP GiantTreeLP added this to Done in 2.2.0 Apr 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
done This issue has been dealt with and will be closed with the next pull request into master rework Some enhancements have to be made
Projects
No open projects
2.2.0
  
Done
Code quality
  
In progress
Development

No branches or pull requests

2 participants