Add Force Unwrapping Rule to SwiftLint #1749
Conversation
|
Should this also include a fix for this one: 
|
|
As far as I know, this is in a separate repository. Abe has already fixed the issue, but we need to create another release. |
|
I can do a release and update the version in CE first thing tomorrow morning. |
activcoding
requested review from
thecoolwinter,
austincondiff,
matthijseikelenboom and
FastestMolasses
|
Looks like there's a ton of new lint errors from force unwrapping. Is it possible to write some custom rules so that we don't have to disable the linter for specific lines? For example in cases like this where we know a value already exists: private var abc = URL("")! |
activcoding
dismissed stale reviews from matthijseikelenboom and FastestMolasses
via
f14a0f8
|
There are still some errors regarding linting |
|
I left the force unwraps in place because I wasn't certain if removing them would break the code. Additionally, I avoided using |
|
How do we want to proceed here then? Do we merge this and fix it later? I don't think that is a good idea, because then we'd have to check what SwiftLint logs exactly to before we merge (Because it will say the check failed) |
|
I've added |
|
As for the CI failures, I'm not sure about those warnings. I can't see them on my local machine. |
|
@activcoding I'll try to take a look tonight |
|
Do we have plans to remove these |
| if let bundlePath = Bundle.main.path(forResource: "Package", ofType: "resolved") { | ||
| let jsonData = try String(contentsOfFile: bundlePath).data(using: .utf8) | ||
| // swiftlint:disable:next force_unwrapping | ||
| let parsedJSON = try JSONDecoder().decode(AcknowledgementObject.self, from: jsonData!) |
There was a problem hiding this comment.
This should be a guard let, or if let.
There is no need to force unwap this.
| if let bundlePath = Bundle.main.path(forResource: "Package", ofType: "resolved") { | |
| let jsonData = try String(contentsOfFile: bundlePath).data(using: .utf8) | |
| // swiftlint:disable:next force_unwrapping | |
| let parsedJSON = try JSONDecoder().decode(AcknowledgementObject.self, from: jsonData!) | |
| if let bundlePath = Bundle.main.path(forResource: "Package", ofType: "resolved"), | |
| let jsonData = try String(contentsOfFile: bundlePath).data(using: .utf8) { | |
| let parsedJSON = try JSONDecoder().decode(AcknowledgementObject.self, from: jsonData) |
| @@ -131,6 +131,7 @@ class EditorManager: ObservableObject { | |||
| if activeEditorHistory.isEmpty { | |||
| activeEditor = findSomeEditor(excluding: editor) | |||
| } else { | |||
| // swiftlint:disable:next force_unwrapping | |||
| activeEditor = activeEditorHistory.removeFirst()()! | |||
| let window = NSApp.windows.first { $0.identifier?.rawValue == SceneID.settings.rawValue }! | ||
| window.titlebarAppearsTransparent = true |
There was a problem hiding this comment.
Doesn't something like this work?
| let window = NSApp.windows.first { $0.identifier?.rawValue == SceneID.settings.rawValue }! | |
| window.titlebarAppearsTransparent = true | |
| NSApp.windows.first { $0.identifier?.rawValue == SceneID.settings.rawValue }?.titlebarAppearsTransparent = true |
In my experience, without adding swiftlint:disable to every force unwrap, no one will bother to remove them. For the proposed changes, could you open a PR and fix some instances of force unwrapping? |
Description
In PR #1673, we agreed on adding a force unwrapping rule to SwiftLint to improve our code quality across the project. Although this addition is not directly related to the original request in #1673, implementing this rule will help us write cleaner and safer code.
In this PR, I have:
If you come across a file you have worked on or will be working on, please take a moment to fix any linter warnings you encounter. This doesn't need to be done immediately, but can be addressed gradually over time.
Related Issues
Checklist
Screenshots