MediaElement full-screen orientation #1945

armanimichael · 2024-04-02T13:02:31Z

armanimichael
Apr 2, 2024

Is there an existing issue for this?

I have searched the existing issues

Did you read the "Reporting a bug" section on Contributing file?

I have read the "Reporting a bug" section on Contributing file: https://github.com/CommunityToolkit/Maui/blob/main/CONTRIBUTING.md#reporting-a-bug

Current Behavior

If Android is locked in Portrait mode, MediaElement full-screen won't rotate the video horizontally.
See example video

Expected Behavior

Regardless of orientation lock, a video should follow the screen orientation when full-screen.

Steps To Reproduce

With ScreenOrientation = ScreenOrientation.Portrait

Open video in fullscreen
Rotate the device into landscape mode

Link to public reproduction project repository

https://github.com/armanimichael/MediaElementFullScreen

Environment

- .NET MAUI CommunityToolkit.Maui.MediaElement: 3.1.0
- .NET MAUI CommunityToolkit: 8.0.0
- OS: Android 14
- .NET MAUI: 8.0.14

Anything else?

No response

ne0rrmatrix · 2024-04-04T07:56:24Z

ne0rrmatrix
Apr 4, 2024

That is default behavior inherited from android. I opened 3 different media players on android. Youtube, twitch, and Prime Video. The all have the exact same behavior that you describe. I don't see any reason to change that. If the device is rotation locked it should not rotate the video when you change orientation. That is expected and default behavior.

If we change this it would require overriding default behavior and I don't think that is a good idea.

0 replies

armanimichael · 2024-04-04T11:29:38Z

armanimichael
Apr 4, 2024
Author

Thanks for the response @ne0rrmatrix.

I think there's some confusion here, I don't see any issue with this if the device rotation is being disabled by the user.

What looks wrong to me here is preventing the video from adapting to the rotation when I (as a developer) lock the Application to portrait mode (for instance because landscape is not supported for my use-case / UI).

I checked Youtube and Prime Video from your examples, and those applications do support both portrait and landscape mode.

On IOS for instance, MediaElement handles this scenario perfectly (if the application is locked to portrait mode, the video still adapts to landscape)

0 replies

ne0rrmatrix · 2024-04-04T12:55:47Z

ne0rrmatrix
Apr 4, 2024

Yes I think I am confused. Are you saying that you set orientation lock and the android implementation is staying locked? If you lock orientation in Maui you want the video player specifically to ignore that? I'm not sure exactly what it is you are expecting?

0 replies

ne0rrmatrix · 2024-04-04T13:10:44Z

ne0rrmatrix
Apr 4, 2024

I just double-checked and when screen rotation is locked the video does not rotate in Android in a video player by default. I loaded the sample app from repo in portrait mode in both android and iOS. Both exhibit the same behavior. If I lock rotation from the menu it stays in that rotation for the whole time screen rotation is locked.

edit for clarity: I opened the sample app from the Maui Community toolkit. Not the provided sample. Sorry about the any possible confusion. I am now going to do further testing with the provided sample to see the behavior.

0 replies

armanimichael · 2024-04-04T14:59:30Z

armanimichael
Apr 4, 2024
Author

There are two ways to lock the application in portrait mode, by two different actors:

Developers can specify that on MainActivity in the Activity attribute by using ScreenOrientation = ScreenOrientation.Portrait
Users can use the system settings toggle to enable/disable changing the orientation
- On top of this - when locked - the user can force the orientation if they are using the bottom bar with buttons: an icon appears on the right and they can force either landscape or portrait mode (see attached image)

Now, if you try YouTube app on an Android phone. there's no way to use it in landscape mode besides entering video fullscreen mode while watching a landscape video (if the video has portrait proportions, the full screen will remain in portrait mode).
In all other use cases the YouTube app is locked in portrait mode.

Let's say I want to create a YouTube clone.
First thing I would do is go into MainActivity and - as a developer - specify ScreenOrientation = ScreenOrientation.Portrait.

That said, I want my users to be able to tap on the fullscreen button in the video player, and:

Nice to have: that should change the screen orientation forcefully depending if the video is a landscape one
Good enough: that should ignore the system setting (set by the user) and detect screen orientation change and display the video accordingly

0 replies

ne0rrmatrix · 2024-04-04T15:29:46Z

ne0rrmatrix
Apr 4, 2024

Ok. That wouuld be easy to implement as I already have an idea how to do that. Sorry about the confusion. I would be happy to submit a proposal to add the ability to do force rotation like that as an option for developers. I will talk to a team member this morning.

0 replies

armanimichael · 2024-04-04T16:00:10Z

armanimichael
Apr 4, 2024
Author

Awesome, thank you @ne0rrmatrix!

0 replies

ne0rrmatrix · 2024-04-08T02:54:08Z

ne0rrmatrix
Apr 8, 2024

I just checked both my phone and android tablet. The behavior of the device is not as you describe. If I turn on auto rotation in settings it will auto rotate based on orientation in YouTube. This is default behavior of most video apps on Samsung devices. This works for both full screen and not full screen.

I am going to start working on suggested change to allow developers a choice to lock this behavior based on choice. It will be a developer option and not a default behavior.

Edit: I will create a discussion to have the team and community discuss it. I have not yet started working on it.

0 replies

Neotrickster · 2024-04-18T18:15:26Z

Neotrickster
Apr 18, 2024

I have the same case, my app is Portrait for everything but 1 page (the one with MediaElement) so I just add some android specific code in OnAppearing and OnDisappearing so change only when enter the page and leave the one who have before changed when leave the page.

I just see @ne0rrmatrix have a OnFullscreenButtonClick method mentioned but I don´t know atm how to access it, but I´m guessing that method will be a better place to put the code I´m refereing.

Hopefully this will not be needed at all when a better solution founded but maybe works for some people in the meantime.

object SOToRestore {  get; set; }

protected override void OnAppearing()
{
    base.OnAppearing();

#if ANDROID
SOToRestore = Microsoft.Maui.ApplicationModel.Platform.CurrentActivity.RequestedOrientation;
Microsoft.Maui.ApplicationModel.Platform.CurrentActivity.RequestedOrientation = Android.Content.PM.ScreenOrientation.Unspecified;
#endif
}

protected override void OnDisappearing()
{
    base.OnDisappearing();

#if ANDROID
    if (SOToRestore is Android.Content.PM.ScreenOrientation SO) Microsoft.Maui.ApplicationModel.Platform.CurrentActivity.RequestedOrientation = Android.Content.PM.ScreenOrientation.Portrait;
#endif
}

0 replies

Neotrickster · 2024-05-22T16:33:34Z

Neotrickster
May 22, 2024

I just checked both my phone and android tablet. The behavior of the device is not as you describe. If I turn on auto rotation in settings it will auto rotate based on orientation in YouTube. This is default behavior of most video apps on Samsung devices. This works for both full screen and not full screen.

I am going to start working on suggested change to allow developers a choice to lock this behavior based on choice. It will be a developer option and not a default behavior.

Edit: I will create a discussion to have the team and community discuss it. I have not yet started working on it.

Is the discussion setting already ?? I can´t find any.

0 replies

Neotrickster · 2024-05-22T16:37:40Z

Neotrickster
May 22, 2024

...
* Nice to have: that should change the screen orientation forcefully depending if the video is a landscape one
* Good enough: that should ignore the system setting (set by the user) and detect screen orientation change and display the video accordingly
...

I just add in "Nice to have" a way to know if the FullScreen button is clicked or a flag to know if MediaElement is on FullScreen/Normal, atm just have OnSizeAllocated but don´t help that much without the flag/method

0 replies

Neotrickster · 2024-06-11T22:46:48Z

Neotrickster
Jun 11, 2024

I just checked both my phone and android tablet. The behavior of the device is not as you describe. If I turn on auto rotation in settings it will auto rotate based on orientation in YouTube. This is default behavior of most video apps on Samsung devices. This works for both full screen and not full screen.

I am going to start working on suggested change to allow developers a choice to lock this behavior based on choice. It will be a developer option and not a default behavior.

Edit: I will create a discussion to have the team and community discuss it. I have not yet started working on it.

Just for reference related: #1748 (comment)

0 replies

ne0rrmatrix · 2024-06-11T22:52:04Z

ne0rrmatrix
Jun 11, 2024

Feel free to create a discussion to start getting the ball rolling @Neotrickster

0 replies

Neotrickster · 2024-06-11T22:59:24Z

Neotrickster
Jun 11, 2024

Thanks man

0 replies

ne0rrmatrix · 2024-06-18T04:24:32Z

ne0rrmatrix
Jun 18, 2024

@vhugogarcia I think this one can be moved to a discussion?

0 replies

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MediaElement full-screen orientation #1945

{{title}}

Replies: 15 comments

{{title}}

{{title}}

{{title}}

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

{{title}}

{{title}}

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

Select a reply

MediaElement full-screen orientation #1945

Is there an existing issue for this?

Did you read the "Reporting a bug" section on Contributing file?

Current Behavior

Expected Behavior

Steps To Reproduce

Link to public reproduction project repository

Environment

Anything else?

Replies: 15 comments

armanimichael Apr 4, 2024 Author

armanimichael Apr 4, 2024 Author

armanimichael Apr 4, 2024 Author

armanimichael
Apr 4, 2024
Author

armanimichael
Apr 4, 2024
Author

armanimichael
Apr 4, 2024
Author