Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define & implement generic rank-to-rank lower comparison operator #412

Open
ppebay opened this issue Jul 20, 2023 · 0 comments
Open

Define & implement generic rank-to-rank lower comparison operator #412

ppebay opened this issue Jul 20, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@ppebay
Copy link
Contributor

ppebay commented Jul 20, 2023

PR #325 introduced the following less-than comparison operator of Rank instances:

    def __lt__(self, other):
        return self.get_load() < other.get_load()

However we do not necessarily want this to be always the comparison operator between ranks, as they can be sorted by other QoIs (like index, work, etc.). This issue must be discussed and only after consensus is reached, implemented more generically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants