Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using ps:exec overwrites config #155

Open
nixme opened this issue Dec 9, 2019 · 3 comments
Open

Using ps:exec overwrites config #155

nixme opened this issue Dec 9, 2019 · 3 comments
Assignees

Comments

@nixme
Copy link

nixme commented Dec 9, 2019

Because the buildpack installs extra.sh into /app/.profile.d/datadog.sh if you SSH into a running dyno with heroku ps:exec that script will execute on login, modifying the (running) agent's conf.yml and integrations.

This is especially an issue because the environment for ps:exec doesn't set all the heroku config vars. So the script overwrites the agent configuration with basically a not-configured conf file.

@nixme
Copy link
Author

nixme commented Dec 10, 2019

I think a better approach would be similar to bin/start-nginx in the https://github.com/heroku/heroku-buildpack-nginx

Then user's of the buildpack would opt-in via the Procfile: web: bin/start-datadog bundle exec bin/puma

@arapulido
Copy link
Collaborator

@nixme Thanks for the suggestion! We will see how we could improve this

@arapulido arapulido self-assigned this Feb 20, 2020
@jeffblake
Copy link

I am also running into this issue, trying to SSH into a dyno to check integrations that only run in the web dyno, not a one-off run process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants