Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent Marking Pins at 0,0 #44

Open
milo-trujillo opened this issue Oct 22, 2017 · 0 comments
Open

Prevent Marking Pins at 0,0 #44

milo-trujillo opened this issue Oct 22, 2017 · 0 comments

Comments

@milo-trujillo
Copy link
Member

We occasionally get a rogue camera marked at latitude 0, longitude 0 (off the west coast of Africa). This could be a few things:

  • Someone playing with our API and marking a camera there accidentally
  • Some platform (probably some Android device) that returns 0,0 as a location before GPS is fully initialized

Assuming it's the second problem then this is non-malicious behavior, but we should add an condition to either the client or the server to prevent sending the marking request if the location is 0,0.

--- Update ---

Confirmed - on Android the system will return 0,0 for a location if you're indoors and can't get a GPS signal. Not sure why they went that route instead of not giving a GPS ping.

Removing the iOS tag since it's an Android bug, and removing the server tag since the server now ignores pin markings at 0,0. Leaving the Android low-priority tag, since we should check client-side and not even make the request if we don't have a real GPS fix yet.

--- Second Update ---

Re-added server tag, since evidence suggests the server is not ignoring cameras marked at 0,0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants