Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use max_properties to truncate the number of parameters in GET requests #104

Open
stephlocke opened this issue Feb 28, 2020 · 0 comments
Open
Labels

Comments

@stephlocke
Copy link
Collaborator

It looks like the functionality to avoid sending too long a request to hubspot has been lost in translation, at least on the deals functionality.

Before we send a set of properties to the query construction, we should apply properties <- properties[seq_len(max_properties)] when max_properties exists as a variable.

Functions should be checked for this issue and any functions found to have max_properties should have the appropriate truncation and also unit tests that validate we request the truncated amount.

(Note #103 shows that hubspot may send us back more properties than we asked for so testing the return may not be initially the recommended approach)

@miahatton miahatton removed their assignment Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants