Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inconsistency of mz window in chromatgram #1390

Open
LiChenPU opened this issue Mar 17, 2021 · 4 comments
Open

inconsistency of mz window in chromatgram #1390

LiChenPU opened this issue Mar 17, 2021 · 4 comments
Assignees

Comments

@LiChenPU
Copy link

Describe the bug
Inconsistency of mz window in chromatgram.
Type compound name in mz search box (top right) uses m/z columns from compound list;
Type compound name in compound search box (left) uses formula calculated m/z from compound list;

To Reproduce

compound search box

mz search box

Expected behavior
Type in the same compound name should give same mz window in chromatgram.

Screenshots
If applicable, add screenshots to help explain your problem.

System (please complete the following information):
Win 10
version 12.0

Additional context
Add any other context about the problem here.

@saif-el
Copy link
Collaborator

saif-el commented Mar 17, 2021

@LiChenPU Thank you for reporting this subtle bug! We will definitely fix this.

@saif-el saif-el self-assigned this Mar 17, 2021
@LiChenPU
Copy link
Author

BTW, formula may be more preferred.

@saif-el
Copy link
Collaborator

saif-el commented Mar 17, 2021

If available, formula is always preferred over raw m/z values. We will make sure that it stays true for this case as well.

@saif-el
Copy link
Collaborator

saif-el commented Mar 22, 2021

@LiChenPU I am not able to reproduce this issue on neither on v0.12.0 nor on our latest development build. But clearly you are getting two very different values in your screenshots.

Some time back, we fixed an issue where the global charge was not affecting mass calculation for compounds with formulae when adduct mode was turned-on but isotope mode was turned-off. I suspect this has to do something with that issue. A fix has been merged and can be tried out in our latest (unstable) builds for Windows and macOS. Can you try this build and see if your bug goes away?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants